-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate describeEnum
.
#8571
Merged
Merged
Deprecate describeEnum
.
#8571
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
--- | ||
title: Migration guide for describeEnum | ||
description: Removal of describeEnum and how to migrate | ||
--- | ||
|
||
## Summary | ||
|
||
The global method `describeEnum` has been deprecated. Existing uses | ||
of `describeEnum(Enum.something)` should use | ||
`Enum.something.name` instead. | ||
|
||
## Context | ||
|
||
Dart 2.17 introduced enhanced enums. With them, Enum became a type | ||
and all enums got a `name` getter, which made `describeEnum` redundant. | ||
|
||
The `describeEnum` method was used to convert an enum value to a string, | ||
since `Enum.something.toString()` would produce `Enum.something` instead | ||
of `something`, which a lot of users wanted. Now, the `name` getter does this. | ||
|
||
## Description of change | ||
|
||
Remove `describeEnum`. | ||
|
||
- Replace `describeEnum(Enum.something)` with `Enum.something.name`. | ||
|
||
## Migration guide | ||
|
||
If you used `describeEnum(Enum.field)` to acesss the string value from an | ||
enum, you can now call `Enum.field.name`. | ||
|
||
Code before migration: | ||
|
||
<!-- skip --> | ||
```dart | ||
enum MyEnum { paper, rock } | ||
|
||
print(describeEnum(MyEnum.paper)); // output: paper | ||
``` | ||
|
||
Code after migration: | ||
|
||
<!-- skip --> | ||
```dart | ||
enum MyEnum { paper, rock } | ||
|
||
print(MyEnum.paper.name); // output: paper | ||
``` | ||
|
||
## Timeline | ||
|
||
Landed in version: TBD<br> | ||
In stable release: not yet | ||
|
||
## References | ||
|
||
{% include docs/master-api.md %} | ||
|
||
API documentation: | ||
|
||
* [`describeEnum` stable][] | ||
* [`describeEnum` main][] | ||
|
||
Relevant issues: | ||
|
||
* [☂️ Cleanup SemanticsFlag and SemanticsAction issue][] | ||
|
||
Relevant PRs: | ||
|
||
* [Deprecate `describeEnum` PR][] | ||
|
||
<!-- Stable channel link: --> | ||
[`describeEnum` stable]: {{site.api}}/flutter/lib/src/foundation/describeEnum.html | ||
|
||
<!-- Master channel link: --> | ||
{% include docs/master-api.md %} | ||
|
||
[`describeEnum` main]: {{site.master-api}}/flutter/lib/src/foundation/describeEnum.html | ||
|
||
[☂️ Cleanup SemanticsFlag and SemanticsAction issue]: {{site.repo.flutter}}/issues/123346 | ||
[Deprecate `describeEnum` PR]: {{site.repo.flutter}}/pull/125016 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out this TBD with the info on when this landed.