Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Impeller video with a newer video #8918

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Replace the Impeller video with a newer video #8918

merged 3 commits into from
Jun 26, 2023

Conversation

sfshaza2
Copy link
Contributor

Fixes #8906

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Visit the preview URL for this PR (updated for commit 0f40b10):

https://flutter-docs-prod--pr8918-impeller-h3115ygy.web.app

(expires Mon, 10 Jul 2023 16:00:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

@atsansone atsansone added the st.RFM Ready to merge or land label Jun 23, 2023
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment:

src/perf/impeller.md Outdated Show resolved Hide resolved
@parlough parlough added st.RFM.% Ready to merge or land with minor changes. No further review needed. and removed st.RFM Ready to merge or land labels Jun 23, 2023
@parlough parlough added st.RFM Ready to merge or land and removed st.RFM.% Ready to merge or land with minor changes. No further review needed. labels Jun 26, 2023
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting that! Looks good to me :D

@sfshaza2 sfshaza2 merged commit 3bb7a48 into main Jun 26, 2023
@sfshaza2 sfshaza2 deleted the impeller branch June 26, 2023 18:58
@sfshaza2 sfshaza2 removed the st.RFM Ready to merge or land label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Impeller I/O video into docs
3 participants