Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master-api with the new main-api links. #9751

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

godofredoc
Copy link
Contributor

This is to replace remove the master-docs-flutter-dev gcp project.

Bug: flutter/flutter#133877

Presubmit checklist

This is to replace remove the master-docs-flutter-dev gcp project.

Bug: flutter/flutter#133877
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that migration and then updating these references @godofredoc! Looks good to me :)

It seems main-api is a bit behind master-api, will the automatic deploy be updated to the main version soon?

It's still fine to land this even if it's a bit behind for a few days though :)

@godofredoc
Copy link
Contributor Author

Thanks for working on that migration and then updating these references @godofredoc! Looks good to me :)

It seems main-api is a bit behind master-api, will the automatic deploy be updated to the main version soon?

It's still fine to land this even if it's a bit behind for a few days though :)

flutter/flutter#137726 will start uploading docs to main on every flutter commit, once that change lands we'll be ready to land this one.

@atsansone atsansone merged commit efd0a45 into flutter:main Nov 2, 2023
8 checks passed
atsansone pushed a commit to atsansone/website that referenced this pull request Nov 14, 2023
This is to replace remove the master-docs-flutter-dev gcp project.

Bug: flutter/flutter#133877

## Presubmit checklist

- [X] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [X] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [X] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants