Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: synced members of Scaffold and AppBar #104

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

daadu
Copy link
Member

@daadu daadu commented Dec 18, 2021

Closes #98

@daadu daadu marked this pull request as ready for review December 18, 2021 11:43
@daadu daadu requested a review from WieFel December 18, 2021 11:43
shape: shape,
backgroundColor: backgroundColor,
foregroundColor: foregroundColor,
// ignore: deprecated_member_use, deprecated_member_use_from_same_package
brightness: brightness,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brightness and textTheme are deprecated but not removed by flutter. Will do the same - will remove when flutter removes it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daadu daadu merged commit 8c86380 into fluttercommunity:master Dec 18, 2021
@daadu daadu deleted the sync-scaffold-appbar branch December 18, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AppBar.SystemOverlayStyle instead of AppBar.Brightness
2 participants