Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added concealBacklayerOnBackButton option #133

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat: added concealBacklayerOnBackButton option #133

merged 4 commits into from
Sep 6, 2023

Conversation

daadu
Copy link
Member

@daadu daadu commented Sep 6, 2023

Closes #132

@daadu
Copy link
Member Author

daadu commented Sep 6, 2023 •
edited
Loading

@WieFel I think we should completely avoid wrapping WillPopScope in case the user does not want this behaviour.

that way user can control that behaviour as per his need.

@daadu daadu requested a review from WieFel September 6, 2023 10:43
WieFel
WieFel approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@WieFel WieFel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even better!

@daadu daadu merged commit f2a1ec0 into fluttercommunity:master Sep 6, 2023
@daadu daadu deleted the fr-concealBacklayerOnBackButton branch September 6, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WieFel WieFel WieFel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing Back button cause visible frontLayer
2 participants
@daadu @WieFel