Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar does not follow drag #789

Closed
koutaro-masaki opened this issue Oct 20, 2023 · 7 comments
Closed

Progress bar does not follow drag #789

koutaro-masaki opened this issue Oct 20, 2023 · 7 comments

Comments

@koutaro-masaki
Copy link
Contributor

When you grab and slide the progress bar, you would expect the pointer to follow your finger, but Chewie doesn't do that.
It seems that the _latestDraggableOffset is not passed to the StaticProgressBar and the update is not reflected, is this intended?

#712

@basemkhirat
Copy link

good to fix this

@ashanftw
Copy link

#797

im having the same issue

@diegotori
Copy link
Collaborator

@koutaro-masaki I'll look into this sometime this week. If you have a PR that fixes this, I'll be happy to review it. Thanks.

diegotori added a commit that referenced this issue Nov 27, 2023
…low-drag

Fix: Progress bar does not follow drag #789
@ashanftw
Copy link

@diegotori Would you be able to publish the fix to the package?

@diegotori
Copy link
Collaborator

I'll make an effort first thing tomorrow. Gonna be out of the country for two weeks, so I'll try to squeeze it before I head out.

@diegotori
Copy link
Collaborator

Published in version 1.7.2.

@ashanftw
Copy link

Thank you!

lg8294 added a commit to lg8294/chewie that referenced this issue Dec 6, 2023
* commit '909423d57a3e49953279210090725962571298e5':
  chewie, version 1.7.2. Addresses fluttercommunity#789.
  refactor: Remove unnecessary nullability
  fix: lint issue
  fix: Restrict pointer to progress bar bounds
  fix: pass latestDraggableOffset to _ProgressBarPainter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants