Uniform controls #599
Merged
Uniform controls #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BuginRug please run |
|
@BuginRug if possible, please run and address the issues from |
|
LGTM, standby for merge. |
diegotori
added a commit
that referenced
this pull request
Feb 18, 2022
codenameakshay
pushed a commit
to qoohoo-app/chewie
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of the Subtitle Togglers from the Options menu reduces redundancy, plus the user may want to use the menu for more complex, subtitle-related options (e.g. support multiple languages) and label them "Subtitles"
The removal of the 'final' keyword from the subtitleBuilder will allow the user to change the appearance of the subtitles at runtime, allowing additional options like changing the subtitle size, color etc... by passing a new subtitleBuilder function