chore: Move very_good_analysis to dev_dependencies #634
Conversation
| @@ -14,7 +14,6 @@ dependencies: | |||
| provider: ^6.0.1 | |||
| video_player: ^2.2.7 | |||
| wakelock: ^0.6.1+1 | |||
| very_good_analysis: ^2.4.0 | |||
There was a problem hiding this comment.
This should be moved to dev_dependencies instead.
There was a problem hiding this comment.
It is not used. Having it or not doesn't make any difference.
There was a problem hiding this comment.
You can notice that because there is no entry on the pubspec.lock
There was a problem hiding this comment.
Still though, if we decide to increase the analysis options in the future, we want to be able to pull lint rules from there.
There was a problem hiding this comment.
But then you are still able to add it when it is decided you want to use it?
If you really want it to be there even though it is not used I can add it, but it sounds a bit of a waste. I wouldn't recommend on installing libraries just in case it might be used in the future.
There was a problem hiding this comment.
I have a long list of housekeeping items that I will get to in the near future. Analysis is one of them. Just need to carve out the time for that very soon.
There was a problem hiding this comment.
Also, there's no harm in leaving something in dev_dependencies that will never get exposed to end users, even if not really used yet.
There was a problem hiding this comment.
No harm, but it can cause confusion. I've moved it to dev_dependencies
There was a problem hiding this comment.
I agree with @JCQuintas. Adding a dependency which is not used makes no sense and confuse other developers.
There was a problem hiding this comment.
If you want to use very_good_analysis later than add it when you need it. I see no advantage in adding a dependency which is not used.
JCQuintas
changed the title
|
LGTM. |
* commit '3948d23733638d8a58ea5ff065abfe96934d2373': (110 commits) Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunity#646. Update pubspec.yaml version updates fix: change video type fix: format and migration artifacts fix: apply diegotori suggestion feat: added support for apple and desktop version feat: Make progressIndicatorDelay a Duration fix: simplify assignation fix: name fix: let the android player buffer before seeking once more fix: removed old code fix: lint feat: added method to set progress delay feat: added example debug feat: add a delay before displaying progress indicator Version 1.3.3. Adds PR fluttercommunity#634. Update pubspec.yaml chore: remove unused dependency Version 1.3.2. Adds PR fluttercommunity#626. ... # Conflicts: # example/ios/Runner.xcodeproj/project.pbxproj # example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme # example/ios/Runner/Info.plist # example/lib/main.dart # example/pubspec.yaml # lib/src/chewie_player.dart # pubspec.yaml
very_good_analysis: 3.0.0