Fix for CenterPlayButton UI bug when using Material 3 #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
requested changes
Sep 9, 2022
diegotori
approved these changes
Sep 9, 2022
|
Gonna try them out on my end very shortly, but if they look good, then they'll get merged. |
|
LGTM, merging very shortly. |
diegotori
added a commit
that referenced
this pull request
Sep 9, 2022
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Sep 22, 2022
* master: Version 1.3.5. Addresses PRs fluttercommunity#658 and fluttercommunity#669. Added slight fix to analysis_options.yaml. Updated video_player to version 2.4.7. Upgraded wakelock to version 0.6.2. Library is now using flutter_lints. - Removed leading underscores for local identifiers - CenterPlayButton padding improved - Example AppTheme updated to useMaterial3 - Several lints fixed for better performance - CenterPlayButton UI bug fixed when using Material 3 - Exposing MaterialDesktopControls Add transformationController to Interactive Viewer fix: Typos in `ChewieController` docs Fixed a typo in the most recent CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Material 3, the AnimatedOpacity of CenterPlayButton expands to fill the available space, and looks like this:
This PR fixes it, and in addition: