-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Seek buttons for Android #703
Conversation
If you can accomplish this for @brianegan any thoughts on this proposed change, since that would be nice if users were able to seek. |
Isn't this the one that you are referring to |
Please merge this PR, because Android need this feature |
We can't merge changes without investigating and the changes are done which @diegotori requested. Please update your PR accordingly and we will test this :) |
@Ahmadre if you have capacity, please review his changes by running them locally. I wanna say that there were exceptions thrown due to the current library calling Thanks. |
LGTM @diegotori Your change requests seems to be implemented. We can merge this if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Ahmadre can you please submit a follow-up PR that fixes lint issues related to this one? Thanks. |
@Ahmadre nevermind, managed to nip it when publishing |
Adding Forward and Backward seek buttons for Android.
Fixes #615