Update for the overlay builder #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
requested changes
Apr 3, 2023
| @@ -390,6 +393,9 @@ class ChewieController extends ChangeNotifier { | |||
|
|
|||
| static const defaultHideControlsTimer = Duration(seconds: 3); | |||
|
|
|||
| /// Define here your own Widget on how your overlay will look | |||
| Widget Function(BuildContext context)? overlayBuilder; | |||
There was a problem hiding this comment.
This should be final since we're trying to make the controller immutable.
Comment on lines
+24
to
+30
| if(chewieController.overlayBuilder != null) { | ||
| return chewieController.overlayBuilder!(context); | ||
| } | ||
| if (chewieController.overlay != null) { | ||
| return chewieController.overlay!; | ||
| } | ||
| return const SizedBox.shrink(); |
There was a problem hiding this comment.
This should be chained as an if-else statement, with it defaulting to SizedBox.shrink().
For bonus credit, instead of using a function to compute the correct Widget to return, why not move it into a standalone widget that takes in the current controller and computes it when build is called on it.
|
@murphycrosby if you have the time to work on the requested changes, then I'll be able to review them. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#665