Fix overlay not visible #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that causes usability issues when controls are similar color as the video
|
Hi @diegotori, is there something preventing to merge this fix, or is there something to improve in the changes? |
|
@jaripekkala looks good to me. Thanks for your contribution. |
|
Thanks. A new patch release would be super. Usability is super important for our app. |
diegotori
added a commit
that referenced
this pull request
May 11, 2023
Currently live in version Thank you for your contribution. |
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
May 12, 2023
* master: Version 1.5.0. Addresses PR fluttercommunity#712. Upgraded iOS Example App's Xcode files. Added latest dart format changes. Fixed app.dart lint issues. Added CI fixes due to Dart 3. Version 1.4.1. Addresses PR fluttercommunity#719. Fix overlay not visible Update progress_bar.dart again fix(ci): deprecated command again Update progress_bar.dart Update progress_bar.dart Update chewie_player.dart # Conflicts: # example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes usability issues, when controls are similar color as the video
Broken since v1.3.5