Stop force disabling wakelock #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue where chewie will force disable wakelock without taking into account that other packages / app parts might depend on the same package
|
LGTM. Once automated checks pass, then you're good to go. |
diegotori
added a commit
that referenced
this pull request
Sep 9, 2023
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Nov 3, 2023
* master: Chewie, version 1.7.0. Adds pull request fluttercommunity#772. Upgraded iOS example project's files. fix: stop force disable wakelock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue where Chewie will force disable Wakelock without taking into account that other packages / app parts might depend on the same package.
In my case, the screen will be able to sleep again after exiting fullscreen, even though we don't want it to while the player is running.
Edit: If needed, for context as to why I removed the comment above the code. It was relevant over 3 years ago, when "sleep" was replaced with Wakelock and a comment was written to explain why the if statement was removed. Yes, we don't have to check if wakelock is enabled anymore, but we should still check if we were the ones that enabled it and not override any custom implementations an app may have.