Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] fix exit full screen issue #810

Merged

Conversation

ToddZeil
Copy link
Contributor

@ToddZeil ToddZeil commented Jan 18, 2024

#790
#688

When viewing full screen on web, returning from full screen causes original video to lose picture.
We re initialise controllers for web only when returning from full screen

Also refactor un needed set states, refactor play if finished( as video player restarts if finished)

@ToddZeil ToddZeil changed the title [Web] fix exit full screen issue #790 #688 [Web] fix exit full screen issue Jan 18, 2024
@ToddZeil ToddZeil changed the title #790 #688 [Web] fix exit full screen issue [Web] fix exit full screen issue Jan 18, 2024
@diegotori
Copy link
Collaborator

diegotori commented Jan 18, 2024

@ToddZeil thanks for your pending changes.

Definitely like the setState refactoring, since that will definitely go towards fixing this long term.

refactor play if finished( as video player restarts if finished)

This should actually be tied to ChewieController.looping, which calls out to VideoPlayerController.setLooping. In other words, it should only set the Duration back to zero if the underlying VideoPlayerController is currently looping.

Once that's done, then that should be good enough for me to approve and merge.

@ToddZeil
Copy link
Contributor Author

@diegotori fair call, added those comments now

@ToddZeil
Copy link
Contributor Author

ToddZeil commented Feb 4, 2024

@diegotori are you happy with the added comments ?

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that I'll merge and publish this tomorrow, since I don't have my development computer in front of me.

@diegotori diegotori merged commit 915e6fa into fluttercommunity:master Feb 8, 2024
2 checks passed
diegotori added a commit that referenced this pull request Feb 8, 2024
lg8294 added a commit to lg8294/chewie that referenced this pull request Aug 27, 2024
* commit '33e95c0b786d245fc1149cddb34141e1a626ce87':
  chewie, version 1.7.5. Addresses fluttercommunity#802 and fluttercommunity#810.
  Add documentation to the play function
  update version and changelog
  Add documentation
  Refactor un needed set states, refactor play if finished( as video player restarts if finished)
  Add fix for returning from full screen web
  Update chewie_player.dart

# Conflicts:
#	lib/src/chewie_player.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants