[Web] fix exit full screen issue #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddZeil
changed the title
ToddZeil
changed the title
|
@ToddZeil thanks for your pending changes. Definitely like the
This should actually be tied to Once that's done, then that should be good enough for me to approve and merge. |
diegotori
requested changes
Jan 18, 2024
diegotori
requested changes
Jan 21, 2024
|
@diegotori fair call, added those comments now |
|
@diegotori are you happy with the added comments ? |
diegotori
approved these changes
Feb 4, 2024
diegotori
added a commit
that referenced
this pull request
Feb 8, 2024
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Aug 27, 2024
* commit '33e95c0b786d245fc1149cddb34141e1a626ce87': chewie, version 1.7.5. Addresses fluttercommunity#802 and fluttercommunity#810. Add documentation to the play function update version and changelog Add documentation Refactor un needed set states, refactor play if finished( as video player restarts if finished) Add fix for returning from full screen web Update chewie_player.dart # Conflicts: # lib/src/chewie_player.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#790
#688
When viewing full screen on web, returning from full screen causes original video to lose picture.
We re initialise controllers for web only when returning from full screen
Also refactor un needed set states, refactor play if finished( as video player restarts if finished)