Fix the logic of the Center Play Button icon selection #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good! |
|
Will this be merged soon? :) In the meantime for others, here is my fork: https://github.com/EmreDET/chewie chewie:
git:
url: https://github.com/EmreDET/chewie.git
ref: master |
|
@EmreDET Thank you for your contribution. Please confirm that this issue also applies to Cupertino as well. If it does, then apply the same fix there as well. The earliest I'll be able to deploy this will be on Monday. |
|
Hey @diegotori, thank you for your quick response. Please let me know if I did something wrong. Thank you. |
diegotori
added a commit
that referenced
this pull request
Aug 5, 2024
|
@EmreDET published in version |
ganeshh123
pushed a commit
to greg-mat/chewie
that referenced
this pull request
Aug 24, 2024
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Aug 27, 2024
* commit 'f58a65003cb3650e7c85e7bc4907454d03bf68a3': chewie, version 1.8.3. Adds PR fluttercommunity#828. Updated workflows so that they now run tests as a result of this PR. format add small test for verification add fix for cupertino & desktop recreate ios project to make it runnable again Update material_controls.dart fix: isFinished is true only if initialized else false # Conflicts: # example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is a small fix. We saw that the plugin has a logical error whenever we did not initialize the video, the icon for the play button would show the "reload"-icon. This happens because:
_latestValue.position >= _latestValue.durationindicates, that if duration was 0, the initial position would also be 0, therefore the video player icon logic falsely assumed that the video needs to be "reloaded" from the beginning. With this simple fix&& _latestValue.duration.inSeconds > 0we ensure, that it should only be treated as "isFinished" if the duration is non-zero, therefore was initialized. If needed, we can even do&& _latestValue.duration.inMilliseconds > 0or_latestValue.duration.inMicroseconds > 0, for further precision.Please correct me if I have made a mistake.
Thank you for your time and efforts.
Emre Y.