Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to set cookies to webview when loading url #110

Closed
wants to merge 2 commits into from
Closed

Added option to set cookies to webview when loading url #110

wants to merge 2 commits into from

Conversation

BWMuller
Copy link

Please note that the iOS code is untested

@gregkorossy
Copy link

When is this functionality going to be added?

@ghost
Copy link

ghost commented Jul 6, 2018

Its presumably tested only in the Simulator ?

@BWMuller
Copy link
Author

BWMuller commented Jul 6, 2018

@Gericop @gedw99 Its tested on android (Physical device)
Untested on iOS due to not having current access to a mac

@gregkorossy
Copy link

This solution is not really good as it only allows cookies to be set by name-value pairs, however, cookies can have more attributes, e.g. Path, HttpOnly, etc. Also, the cookie's URL is set by the opened URL which means if I open the site "https://example.com/something/" the cookie will only work for the /something path due to the missing Path attribute of the cookie.

On iOS the attributes are explicitly set, for example Path is set to /, however, this also means that if the cookie you want to set has this value, it's gonna get overridden by the implementation.

@BWMuller
Merge branch 'master' of https://github.com/fluttercommunity/flutter_…
fccf4c0 
…webview_plugin into fluttercommunity-master

# Conflicts:
#	android/src/main/java/com/flutter_webview_plugin/FlutterWebviewPlugin.java
#	android/src/main/java/com/flutter_webview_plugin/WebviewManager.java
#	ios/Classes/FlutterWebviewPlugin.m
#	lib/src/base.dart
@BWMuller
Copy link
Author

Unable to get this working correctly in iOS, webview is not accepting the cookies at all.

@BWMuller BWMuller closed this Oct 10, 2018
@craigloftus craigloftus mentioned this pull request Nov 15, 2018
Open
@devraj-kumar
Copy link

how this works?

@jims57 jims57 mentioned this pull request Jul 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BWMuller @gregkorossy @devraj-kumar