-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS web view plugin #3
Conversation
Thanks, I will test it, anything to configure or it just work ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add your name as an author in pubspec.yaml, and update the README with an IOS part that explain how to integrate the plugin ?
example/ios/Podfile.lock
Outdated
@@ -1,3 +1,22 @@ | |||
PODFILE CHECKSUM: fe68fbd35e5bc75c5acdec41319edc0cdaebd038 | |||
PODS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this file should be in gitignore
No special setup needed. But I do think the plugin should be updated to work with the new version of the Flutter sdk that uses GeneratedPluginRegistrant. Were you able to test it successfully? |
Yes tested successfuly, I had to update my project. But the clearCookies params does not work, the app just shutdown for me, without error. you can test it, |
Last thing, is it possible to have a parameter to have a completely fullscreen view, without the top bar with the "Done" button ? If you prefer we can do it later, in an other pull request it is not blocking |
- Fixed crash with clearCookies - Added flag to toggle full screen mode - Updated README - Updated pubspec.yaml authors section
I've added the changes you requested, including adding a fullScreen param to toggle full screen mode for the WebView |
ios and android more implement
ios and android more implement
I’m using GeneratedPluginRegistrant because that’s the supported plugin
in the new Flutter version. I couldn’t compile the code without it
unfortunately