Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reloading (Android) #59

Merged
merged 11 commits into from
May 24, 2018
Merged

Conversation

howardt12345
Copy link
Contributor

No description provided.

Copy link
Collaborator

@lejard-h lejard-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added some comments

case "back":
back(call, result);
break;
case "forward":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad code format

@@ -113,6 +113,12 @@ class FlutterWebviewPlugin {
/// Will trigger the [onDestroy] event
Future close() => _channel.invokeMethod("close");

Future reload() => _channel.invokeMethod("reload");

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please comment functions and explain that it is only available on Android for now

@lejard-h
Copy link
Collaborator

Hi, did you take a look at my comments ?

Copy link
Contributor Author

@howardt12345 howardt12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took note of comments and made appropriate changes

@lejard-h
Copy link
Collaborator

great thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants