fix: skipDoubleRegistration with instanceName

fluttercommunity · Oct 6, 2024 · a0d3612 · a0d3612
1 parent 14a177f
commit a0d3612
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/get_it_impl.dart b/lib/get_it_impl.dart
@@ -1586,7 +1586,9 @@ class _GetItImplementation implements GetIt {
         );
 
         /// skip double registration
-        if (skipDoubleRegistration && !allowReassignment) {
+        if (skipDoubleRegistration &&
+            !allowReassignment &&
+            existingTypeRegistration.namedFactories.containsKey(instanceName)) {
           return;
         }
       } else {

diff --git a/test/skip_double_registration_test.dart b/test/skip_double_registration_test.dart
@@ -38,6 +38,27 @@ void main() {
     expect(getIt<DataStore>(), isA<MockDataStore>());
   });
 
+  test(' Ignores Double named registration error ', () async {
+    final getIt = GetIt.instance;
+    const instanceName = 'named';
+    getIt.reset();
+    getIt.allowReassignment = false;
+    getIt.skipDoubleRegistration = true;
+    getIt.registerSingleton<DataStore>(RemoteDataStore());
+    getIt.registerSingleton<DataStore>(
+      MockDataStore(),
+      instanceName: instanceName,
+    );
+    getIt.registerSingleton<DataStore>(MockDataStore());
+    getIt.registerSingleton<DataStore>(
+      RemoteDataStore(),
+      instanceName: instanceName,
+    );
+
+    expect(getIt<DataStore>(), isA<RemoteDataStore>());
+    expect(getIt<DataStore>(instanceName: instanceName), isA<MockDataStore>());
+  });
+
   test(' does not care about [skipDoubleRegistration] varibale   ', () async {
     final getIt = GetIt.instance;
     getIt.reset();