Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFinal test #329

Merged
merged 1 commit into from
May 26, 2023
Merged

isFinal test #329

merged 1 commit into from
May 26, 2023

Conversation

subzero911
Copy link

#326

I added a test but it fails for some reason.

TestClass is not removed after popScope().

@escamoteur
Copy link
Collaborator

I merge and debug

@escamoteur escamoteur merged commit 847089b into fluttercommunity:master May 26, 2023
@escamoteur
Copy link
Collaborator

you have to await popScope

@escamoteur
Copy link
Collaborator

because dispose functions can be async
if you don't await in the test the expect will get executed before the scope is popped

@escamoteur
Copy link
Collaborator

if fixed it and pushed it again

@escamoteur
Copy link
Collaborator

do you also update the readme?

@subzero911
Copy link
Author

#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subzero911 @escamoteur