[battery_plus] add "unknown" status (#61) #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
changed the title
mhadaily
approved these changes
Feb 16, 2021
Member
mhadaily
left a comment
mhadaily
left a comment
There was a problem hiding this comment.
this is a good improvement, lgtm
Member
Author
|
thanks! 🙂 |
2 tasks
Contributor
|
Curious about the fall through (ie lack of break statements) behavior on Android (and iOS) for the unknown state. @jpnurmi are those states intentionally falling through for some reason, or should we add break statements there? |
Member
Author
|
@ChristianEdwardPadilla Good catch, thanks! Could you push a fix? |
Contributor
|
Will do, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "unknown" battery state for batteryless systems (e.g. workstations).
Closes: #61