Skip to content

fix(sensors_plus)!: Use magnetometer instead of deviceMotion #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbuberen merged 1 commit into from
Nov 23, 2023
Merged

fix(sensors_plus)!: Use magnetometer instead of deviceMotion #2250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions packages/sensors_plus/sensors_plus/ios/Classes/FPPStreamHandlerPlus.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class FPPMagnetometerStreamHandlerPlus: NSObject, MotionStreamHandler {
var samplingPeriod = 200000 {
didSet {
_initMotionManager()
_motionManager.deviceMotionUpdateInterval = Double(samplingPeriod) * 0.000001
_motionManager.magnetometerUpdateInterval = Double(samplingPeriod) * 0.000001
}
}

Expand All @@ -192,16 +192,7 @@ class FPPMagnetometerStreamHandlerPlus: NSObject, MotionStreamHandler {
eventSink sink: @escaping FlutterEventSink
) -> FlutterError? {
_initMotionManager()
// Allow iOS to present calibration interaction.
_motionManager.showsDeviceMovementDisplay = true
_motionManager.startDeviceMotionUpdates(
// https://developer.apple.com/documentation/coremotion/cmattitudereferenceframe?language=objc
// "Using this reference frame may require device movement to
// calibrate the magnetometer," which is desired to ensure the
// DeviceMotion actually has updated, calibrated geomagnetic data.
using: CMAttitudeReferenceFrame.xMagneticNorthZVertical,
to: OperationQueue()
) { data, error in
_motionManager.startMagnetometerUpdates(to: OperationQueue()) { data, error in
if _isCleanUp {
return
}
Expand All @@ -213,9 +204,7 @@ class FPPMagnetometerStreamHandlerPlus: NSObject, MotionStreamHandler {
))
return
}
// The `magneticField` is a
// CMCalibratedMagneticField.
let magneticField = data!.magneticField.field
let magneticField = data!.magneticField
sendTriplet(x: magneticField.x, y: magneticField.y, z: magneticField.z, sink: sink)
}
return nil
Expand Down