Skip to content

Conversation

@miquelbeltran
Copy link
Member

Description

When running melos run test:e2e it runs the tests based on the package name, like /test_driver/MELOS_PARENT_PACKAGE_NAME_e2e.dart so for example share_plus expects to run test_driver/share_plus_e2e.dart.

In this PR I rename the files so the we can run melos to run all e2e tests.

Note that I noticed that some tests won't pass, that's another issue :)

Copy link
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miquelbeltran miquelbeltran merged commit 2cfd037 into main Nov 5, 2020
@miquelbeltran miquelbeltran deleted the mb-rename-e2e-tests branch November 5, 2020 19:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants