Skip to content

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Nov 7, 2020

Description

  • generated missing example runner for web
  • share_plus_web was not endorsed in share_plus
  • SharePlugin.registerWith() was creating an instance of the platform interface SharePlatform instead of SharePlugin for web
  • the workaround for pure Dart desktop plugins had the kIsWeb guard in the wrong place

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jpnurmi jpnurmi requested a review from mhadaily November 7, 2020 20:02
@jpnurmi jpnurmi added the share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin label Nov 7, 2020
@miquelbeltran
Copy link
Member

LGTM thanks!

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 8, 2020

Thanks for the review! 👍

@jpnurmi jpnurmi merged commit 313a5ce into fluttercommunity:main Nov 8, 2020
@jpnurmi jpnurmi deleted the fix/share_plus_web branch November 8, 2020 14:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants