[package_info_plus] fix web build (broken by windows & ffi) #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as for path_provider_windows: flutter/plugins@2595703 Moves the real implementation of package_info_plus_windows behind a conditional export, instead exporting a stub on platforms that don't support dart:ffi. This avoids build breakage in web projects that have transitive dependencies on package_info_plus (and thus package_info_plus__windows due to manual endorsement). This will no longer be necessary once flutter/flutter#52267 is fixed, since only Windows builds will ever need to have code-level dependency on package_info_plus_windows.
jpnurmi
changed the title
Member
Author
|
"Nice" 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as flutter/plugins@2595703 for path_provider_windows.
Moves the real implementation of package_info_plus_windows behind a
conditional export, instead exporting a stub on platforms that don't
support dart:ffi. This avoids build breakage in web projects that have
transitive dependencies on package_info_plus (and thus
package_info_plus__windows due to manual endorsement).
This will no longer be necessary once
flutter/flutter#52267 is fixed, since only
Windows builds will ever need to have code-level dependency on
package_info_plus_windows.
Related Issues
flutter/flutter#52267
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change