[share_plus] rename method channel and plugins (#56) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** Plugin method host for presenting a share sheet via Intent */ | ||
| public class SharePlugin implements FlutterPlugin, ActivityAware { | ||
| public class SharePlusPlugin implements FlutterPlugin, ActivityAware { |
Member
There was a problem hiding this comment.
I think renaming the Java class is not necessary but thanks for doing it aways!
miquelbeltran
approved these changes
Dec 12, 2020
Member
miquelbeltran
left a comment
miquelbeltran
left a comment
There was a problem hiding this comment.
thanks a lot!
-> This still needs a new package release (for share_plus and all dependencies). <-
jpnurmi
force-pushed
the
fix/share_plus
branch
from
49f1000 to
0a822a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested:
macOS(N/A)