Replace Future.finally #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The finally function has long been surpassed by Future.hook, and has several problems: 1. An undocumented behaviour where it will run *and cancel* your cleanup Future upon cancellation. This once was intended, and copied to Future.hook, but then it was decided to be bad behaviour and removed from Future.hook. It stuck around in Future.finally. 2. It doesn't clean up when the Future crashes. 3. It's not very useful for any other kind of control flow.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 990 985 -5
Branches 215 215
=====================================
- Hits 990 985 -5
Continue to review full report at Codecov.
|
I've personally been using Future.finally *only* to shorten this:
someFuture
.chain(_ => Future.reject('Kaputt'))
.chainRej(_ => Future.reject('Kaputt'))
To this:
someFuture.finally(Future.reject('Kaputt'))
Now that finally is gone, I'll replace it by a function which does this
job, and does it better (it works for resolved Futures as well).
Avaq
force-pushed
the
avaq/remove-finally
branch
from
f4e9b80
to
17449fa
Compare
|
I'm going to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Future.finally and its aliases
The finally function has long been surpassed by Future.hook, and has
several problems:
cleanup Future upon cancellation. This once was intended, and
copied to Future.hook, but then it was decided to be bad behaviour
and removed from Future.hook. It stuck around in Future.finally.
Add Future.assume to fill the gap that Future.finally left
I've personally been using Future.finally only to shorten this:
To this:
Now that finally is gone, I'll replace it by a function which does this
job, and does it better (it works for resolved Futures as well).