Add pap and remove concurrify #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, parallelAp has been available only to users through usage of the ConcurrentFuture type. However, using it for day-to-day function application is quite cumbersome in comparison to using 'ap' directly. Providing a parallel implementation of ap allows users to use the more convenient API whenever they know they're working with a Future, leaving the ConcurrentFuture type for special usecases only.
This dependency was removed quite some time ago, but the reference to it in the rollup configuration was never removed.
There are various reasons for this change: 1. Concurrify has been conflated with features needed only by Fluture. 2. The approach taken by Concurrify for determining the type identity is no longer compatible with the latest version of sanctuary-type-identifiers. 3. Maintaining concurrify is more trouble than it's worth.
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 45 45
Lines 1896 1957 +61
=====================================
+ Hits 1896 1957 +61
Continue to review full report at Codecov.
|
dicearr
approved these changes
Dec 12, 2019
Avaq
added a commit
that referenced
this pull request
Jan 7, 2020
New Features - #404 (323bdab) Add a 'pap' function: 'ap' in parallel Improvements - #404 (7b6d9fd) Improvements to debuggability of ConcurrentFuture related functions, and removal of an external dependency. - #410 (b465433) Mistake in TypeScript annotations fixed. - #404 (6aaf82d) Mistake in TypeScript annotations fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are three unrelated commits, but because they all touch the same code, I am submitting them in a single PR to avoid having to resolve conflicts afterwards. Every commit contains its own motivation in the commit body.