Fix some issues with value equality #32
Conversation
This fixes an issue where two equivalent instances of Json are not considered equal, because after JSON.stringifying the input object, the key order is taken into account when considering equality.
| }); | ||
|
|
||
| test ('Json', () => { | ||
| eq (lib.Response.is (lib.Json (null)), true); | ||
| eq (lib.Json (null), lib.Json (null)); | ||
| eq (lib.Json ({a: 1, b: 2}), lib.Json ({b: 2, a: 1})); |
There was a problem hiding this comment.
This assertion would fail, previously, because of the key order.
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 461 478 +17
=========================================
+ Hits 461 478 +17
Continue to review full report at Codecov.
|
This function can be (and will be) used more generally to match against a subset of tags, with each of the other tags resulting in the provided default value.
Avaq
force-pushed
the
avaq/setoid
branch
2 times, most recently
from
2ada9c3
to
7fcb535
Compare
| @@ -244,16 +262,15 @@ export const Text = value => Response.Respond ( | |||
| Body.Send (value), | |||
| ); | |||
|
|
|||
| //# Json :: Object -> Response a b | |||
| //# Json :: JsonValue -> Response a b | |||
There was a problem hiding this comment.
Does JsonValue mean something like any JSON-serializable data?
There was a problem hiding this comment.
Yeah. Not all values of type Object are valid input here.
index.js
Outdated
| return this.cata ({ | ||
| None: _ => cataBool ({None: _ => true}) (other), | ||
| Send: a => cataBool ({Send: b => Z.equals (a, b)}) (other), | ||
| Json: a => cataBool ({Json: b => Z.equals (a, b)}) (other), | ||
| Stream: a => cataBool ({Stream: b => a === b}) (other), | ||
| Render: (...a) => cataBool ({Render: (...b) => Z.equals (a, b)}) (other), | ||
| }); |
There was a problem hiding this comment.
You could avoid repeating (other):
return this.cata ({
// ...
}) (other);
This commit fixes an issue where two equivalent values of type Stream are not considered equal. This happens because the inner value of a Stream (a Future) does not implement Setoid. We fix this by using reference equality.
While updating to 5.0 I found my tests' assertions started failing for some of the Json values. These fixes should address that, and similar, problems.