kvs: in module, log to flux logging facility, not stderr #1165
Comments
chu11
added a commit
to chu11/flux-core
that referenced
this issue
Sep 14, 2017
Replace lingering log calls that log to stderr with calls that log to flux logging facility. Requires passing optional flux_t handle to internal lookup and commit APIs. Remove lingering unnecessary includes of log.h throughout. Fixes flux-framework#1165
chu11
added a commit
to chu11/flux-core
that referenced
this issue
Sep 15, 2017
Replace lingering log calls that log to stderr with calls that log to flux logging facility. Requires passing optional flux_t handle to internal lookup and commit APIs. Remove lingering unnecessary includes of log.h throughout. Fixes flux-framework#1165
chu11
added a commit
to chu11/flux-core
that referenced
this issue
Sep 15, 2017
Replace lingering log calls that log to stderr with calls that log to flux logging facility. Requires passing optional flux_t handle to internal lookup and commit APIs. Remove lingering unnecessary includes of log.h throughout. Fixes flux-framework#1165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in #1154, several of the internal KVS apis (i.e. lookup & commit) log to stderr instead of the flux log facility. The reason for this is the flux handle is not available within those APIs, as it was desired to keep those APIs independent of the flux-core and thus could be unit testable by themselves.
However, logging to stderr is non-optimal as well.
Create a facility to pass in the flux handle optionally, so that logging can go to the flux log. Perhaps via a "set option" kind of function or another parameter to main API create functions.
The text was updated successfully, but these errors were encountered: