flux_reactor_run() should return active watcher count #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alter the return value of flux_reactor_run() to return the number of active watchers on success, or -1 on failure. Update tests that check for 0 as success to allow for >= 0. Fixes flux-framework#963
Break some >=80 column lines and remove unnecessary indent. Reword NOWAIT flag description and RETURN VALUE section.
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 77.89% 77.86% -0.03%
==========================================
Files 150 150
Lines 25934 25930 -4
==========================================
- Hits 20200 20190 -10
- Misses 5734 5740 +6
|
|
I didn't notice this before I merged, but does the comment for FLUX_REACTOR_NOWAIT flag in reactor.h need to be changed as well? |
|
oops, sure does. I'll just submit that as a separate PR. |
|
Thanks. Sorry I missed that in review :-( |
|
No prob - would have been better if I'd caught it in the first place! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was split out of PR #1083. It alters the return value of
flux_reactor_run(). On success, return the active watcher count so >= 0 indicates success, not just zero. Drop the code that returned -1 with errno = EWOULDBLOCK if the FLUX_REACTOR_NOWAIT or FLUX_REACTOR_ONCE flag was specified as agreed in #963.