add FLUX_PMI_SINGLETON env variable to avoid SLURM's libpmi in valgrind test #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Valgrind test reports leaks in slurm's libpmi.so on TOSS 2 systems. The broker, or rather our internal PMI library, will try hard to use an external PMI environment if available. On systems where slurm's libpmi.so is installed, the broker, when run without flux-start, will use that, and our valgrind test reports leaks in it. Add environment variable FLUX_PMI_SINGLETON which can be used to force (internal) singleton bootstrap if no other environment variables are set to influence PMI bootstrap. Fixes flux-framework#1090
|
Cool, works for me on the failing system. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 77.98% 78.03% +0.05%
==========================================
Files 151 151
Lines 26105 26105
==========================================
+ Hits 20357 20371 +14
+ Misses 5748 5734 -14
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Valgrind test reports leaks in slurm's libpmi.so
on TOSS 2 systems.
The broker, or rather our internal PMI library, will try
hard to use an external PMI environment if available.
On systems where slurm's libpmi.so is installed, the
broker, when run without flux-start, will use that, and
our valgrind test reports leaks in it.
Add environment variable FLUX_PMI_SINGLETON which can be used
to force (internal) singleton bootstrap if no other
environment variables are set to influence PMI bootstrap.
Fixes #1090