-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common/libutil: Fix base64 API documentation #1138
Conversation
FWIW, I went back and forth on "fix documentation" or "fix function to do what it says". B/c many other functions require |
Oh yep that's true. @dun might want to grab that too, since we raided munge for that code. |
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
+ Coverage 77.57% 77.61% +0.03%
==========================================
Files 157 157
Lines 28679 28678 -1
==========================================
+ Hits 22247 22257 +10
+ Misses 6432 6421 -11
|
You're mixing verb tenses within a sentence. It should read "and sets [dstlen] to the number of bytes written." |
base64_encode_block() and base64_decode_block() require dstlen to be passed in, but the header files say they are optional. Adjust documentation appropriately.
cbe0526
to
e5bf5aa
Compare
fixed and re-pushed |
Thanks guys. |
base64_encode_block() and base64_decode_block() require dstlen
to be passed in, but the header files say they are optional. Adjust
documentation appropriately.