modules/kvs: normalize keys before use #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility function kvs_util_normalize_key() which - transforms consecutive path separators into one - drops leading path separators - drops trailing path separators - preserves "." as such Add unit tests.
Insert key normalization in 1) lookup_create(), which covers "get" and "watch" cases 2) in commit_link_dirent() which covers "put" 3) in kvs_unwatch() Fixes flux-framework#1180 Fixes flux-framework#1173
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
==========================================
- Coverage 77.84% 77.84% -0.01%
==========================================
Files 158 158
Lines 29209 29252 +43
==========================================
+ Hits 22739 22770 +31
- Misses 6470 6482 +12
|
|
Looks good to me! Just waiting for Travis to finish up |
|
Eh, coveralls seems to be slow but we already have coverage report from codecov, so all looks good! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to deal with extra path separators in keys.
Duplicate, leading, and trailing separators are removed, which addresses #1180 and #1173.
Sharness and unit tests are added.