libcompat: cleanup, drop dead and little-used code #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: libcompat functions can only be used by including src/common/libcompat/compat.h. However, that in turn includes json-c, which prevents it from being used by code that has been converted to jansson. Drop compat.h and instead have users directly include the compat modules they need. This also makes it more clear which parts of libcompat are being used.
Drop unnecessary external includes from libcompat headers, and include <flux/core.h> rather than individual internal headers. Fix up users that were getting their includes transitively through the compat headers.
No users for this.
No users for this.
No users for this.
No users for this.
The following functions are dropped due to no users: flux_msghandler_addvec() flux_reactor_start()
grondo
approved these changes
Oct 11, 2017
|
Changes Unknown when pulling 478156b on garlick:compat_cleanup into ** on flux-framework:master**. |
|
restarted a build that failed with #1169 |
Codecov Report
@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 78.21% 78.09% -0.12%
==========================================
Files 158 154 -4
Lines 29298 28660 -638
==========================================
- Hits 22915 22382 -533
+ Misses 6383 6278 -105
|
|
Actually, maybe the |
|
OK, let me see if that breaks anything. |
|
It's actually used by |
|
Hm, code coverage appeared to indicate it wasn't called. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In another PR I was moving some deprecated KVS functions to libcompat and noted that some libcompat code was no longer used, some had only one user and was simple to eliminate, and some headers included from compat headers were wrong. That is cleaned up here.
In addition, the single compat.h include file is a problem if you only want one piece of libcompat, and other pieces conflict. The specific problem I ran into was compat.h bringing in json-c, but needing to use a libcompat KVS function from code that used jansson. This PR drops compat.h and makes the individual headers able to be included directly