generalize valgrind suppression for getaddrinfo #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
=========================================
Coverage ? 77.91%
=========================================
Files ? 154
Lines ? 29093
Branches ? 0
=========================================
Hits ? 22667
Misses ? 6426
Partials ? 0 |
|
This just needs a rebase. Thanks. |
Generalize the suppression entry for leak detected under getaddrinfo() to handle slight difference in call chain under different build environments.
|
Changes Unknown when pulling d1dd627 on grondo:valgrind.supp into ** on flux-framework:master**. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1240, the valgrind test fails when building under spack on recent ubuntu because the stack trace for getaddrinfo() leak is slightly different than the existing suppression entry in this environment. This PR just generalizes that suppression so that any leak under getaddrinfo() is suppressed.