Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/man1/flux-kvs: Update language #1301

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Dec 7, 2017

A number of open source projects have been removing the term "slave" from their lexicon. So to be up with the times, remove "slave" nomenclature that lingered in this manpage.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 78.577% when pulling c5c20af on chu11:masterslaveupdate into 53697fa on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #1301 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
+ Coverage   78.24%   78.28%   +0.04%     
==========================================
  Files         154      154              
  Lines       27935    27935              
==========================================
+ Hits        21857    21869      +12     
+ Misses       6078     6066      -12
Impacted Files Coverage Δ
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/bindings/lua/flux-lua.c 81.16% <0%> (+0.08%) ⬆️
src/common/libflux/message.c 81.6% <0%> (+0.11%) ⬆️
src/broker/content-cache.c 74.73% <0%> (+1.29%) ⬆️
src/broker/module.c 85.19% <0%> (+1.39%) ⬆️

@chu11
Copy link
Member Author

chu11 commented Dec 7, 2017

build hung after

PASS: t4000-issues-test-driver.t 4 - t0900-wreck-invalid-cores.sh

restarting.

@garlick
Copy link
Member

garlick commented Dec 13, 2017

I suggest you go with "leader" and "follower" (or maybe there's a better pair of terms?) instead of rank 0 and rank > 0 since I think the design will need to evolve away from rank 0 specialness. That was the reason for the original language.

@grondo
Copy link
Contributor

grondo commented Dec 13, 2017

I like "follower" which works even if you keep "master".

someone else on the wise internet has suggested primary/secondary or primary/replica, etc.

@chu11
Copy link
Member Author

chu11 commented Dec 13, 2017

Ok, lets go with leader & follower. B/c we hadn't established a nomenclature, I just went with "rank 0" and "rank > 0".

@chu11 chu11 force-pushed the masterslaveupdate branch from c5c20af to dadb04c Compare December 13, 2017 00:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 78.584% when pulling dadb04c on chu11:masterslaveupdate into b43aca0 on flux-framework:master.

@chu11 chu11 force-pushed the masterslaveupdate branch from dadb04c to 380c052 Compare December 13, 2017 01:34
@chu11
Copy link
Member Author

chu11 commented Dec 13, 2017

updated, rebased, and re-pushed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 78.58% when pulling 380c052 on chu11:masterslaveupdate into b43aca0 on flux-framework:master.

Update language to not use master/slave terminology.  Use
leader/follower terminology instead.
@chu11 chu11 force-pushed the masterslaveupdate branch from 380c052 to e7c32d8 Compare December 13, 2017 03:43
@chu11
Copy link
Member Author

chu11 commented Dec 13, 2017

rebased on master again

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 78.612% when pulling e7c32d8 on chu11:masterslaveupdate into c83814e on flux-framework:master.

@garlick
Copy link
Member

garlick commented Dec 13, 2017

Thanks @chu11!

@garlick garlick merged commit 2879f60 into flux-framework:master Dec 13, 2017
@grondo grondo mentioned this pull request May 10, 2018
@chu11 chu11 deleted the masterslaveupdate branch June 5, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants