-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobspec: Use "yaml-cpp" instead of "Yaml-cpp" #1306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
+ Coverage 78.22% 78.28% +0.06%
==========================================
Files 154 154
Lines 27935 27935
==========================================
+ Hits 21851 21868 +17
+ Misses 6084 6067 -17
|
Interesting. I checked on my ubuntu system, and the pc file names the package with upper case Y:
however, only all lower case seems to work with pkg-config:
So looks good to me. Needs a rebase now though (sorry). |
Not a problem. Will do shortly. |
Fix a flux-sched autoconf problem when it uses PKG_CHECK_MODULES to gather libraray info on jobspec package. Apparently pkg-config doesn't like the dependent package name: "Yaml-cpp." On quartz: $ uname -a Linux quartz1916 3.10.0-693.5.2.1chaos.ch6.x86_64 #1 SMP Wed Oct 25 16:20:31 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux $ pkg-config --cflags flux-jobspec Package Yaml-cpp was not found in the pkg-config search path. Perhaps you should add the directory containing `Yaml-cpp.pc' to the PKG_CONFIG_PATH environment variable Package 'Yaml-cpp', required by 'flux-jobspec', not found Get a simiar configure error when PKG_CHECK_MODULES([JOBSPEC],[flux-jobspec],[],[]) is used.
Ok. Rebased and forced a push. |
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flux-sched autoconf problem when it uses
PKG_CHECK_MODULES to gather libraray info on jobspec
package.
Apparently pkg-config doesn't like the dependent
package name: "Yaml-cpp."
On quartz:
$ uname -a
Linux quartz1916 3.10.0-693.5.2.1chaos.ch6.x86_64 #1
SMP Wed Oct 25 16:20:31 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux
$ pkg-config --cflags flux-jobspec
Package Yaml-cpp was not found in the pkg-config search path.
Perhaps you should add the directory containing `Yaml-cpp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'Yaml-cpp', required by 'flux-jobspec', not found
Get a simiar configure error when
PKG_CHECK_MODULES([JOBSPEC],[flux-jobspec],[],[]) is used.