libutil/read_all: fix minor bugs, add test coverage #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the travis builders failed to install GCC 4.9. I restarted one to see if it was a temporary failure... |
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
+ Coverage 78.17% 78.19% +0.01%
==========================================
Files 155 155
Lines 28198 28204 +6
==========================================
+ Hits 22045 22054 +9
+ Misses 6153 6150 -3
|
Problem: readall.[ch] contains function named read_all(). Rename readall.[ch] to read_all.[ch]. Update users.
Problem: read_all() and write_all() use uint8_t * buffer types that are less convenient than void *. Update read_all() and write_all() prototypes to look more like the read(2) and write(2) system calls they wrap. Update callers where needed.
Problem: read_all() leaks internally allocated buffer upon realloc failure, and does not preserve errno in all error paths. Restructure realloc and error handling code to avoid the leak and preserve errno.
garlick
force-pushed
the
read_all_cleanup
branch
from
ea523de to
b57aa38
Compare
|
Rebased on current master. |
|
Looked good, merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libutil/readall.[ch]was misnamed, leaked on realloc failure, didn't preserve errno in all return paths, and lacked test coverage.This PR addresses those issues and updates users where appropriate.