Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anonymous enums kill bindings #1354

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

trws
Copy link
Member

@trws trws commented Mar 14, 2018

Subject says it all, no clue why this works elsewhere but a build on toss2 died without this change.

@trws trws requested a review from garlick March 14, 2018 22:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 78.79% when pulling d2110d2 on trws:fix_python_bindings into 3eea25b on flux-framework:master.

@codecov-io
Copy link

Codecov Report

Merging #1354 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   78.51%   78.47%   -0.04%     
==========================================
  Files         162      162              
  Lines       29741    29741              
==========================================
- Hits        23350    23340      -10     
- Misses       6391     6401      +10
Impacted Files Coverage Δ
src/common/libflux/ev_flux.c 97.56% <0%> (-2.44%) ⬇️
src/connectors/local/local.c 87.4% <0%> (-0.75%) ⬇️
src/common/libflux/msg_handler.c 86.64% <0%> (-0.73%) ⬇️
src/common/libflux/message.c 80.89% <0%> (-0.59%) ⬇️
src/broker/overlay.c 74.14% <0%> (-0.32%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/common/libflux/reactor.c 93.44% <0%> (-0.29%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 83.91% <0%> (+0.24%) ⬆️
src/common/libflux/rpc.c 94.21% <0%> (+0.82%) ⬆️
... and 1 more

@garlick
Copy link
Member

garlick commented Mar 14, 2018

Thanks! Sorry I knew that was problematic for the python binding, but apparently it slipped by anyhow.

@garlick garlick merged commit e8056ed into flux-framework:master Mar 14, 2018
@trws
Copy link
Member Author

trws commented Mar 14, 2018

No worries, just makes me wonder how it passed by all the testing. Maybe it's only an issue for certain versions or something.

@grondo grondo mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants