Fix flux-wreck purge #1357
Merged
Fix flux-wreck purge #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flux-wreck purge attempts to call the `commit` method on a flux handle, the correct method is `kvs_commit`. Not sure how this slipped by, but Fixes flux-framework#1356
Add a sanity check that flux-wreck purge works and can purge jobs.
Avoid a messy runtime error in various flux-wreck command when there is no lwj. kvs directory yet.
|
restarted failed build due to an instance of #1077. Actually accidentally restarted all builds, grrr. |
Codecov Report
@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
+ Coverage 78.51% 78.55% +0.04%
==========================================
Files 162 162
Lines 29741 29741
==========================================
+ Hits 23350 23362 +12
+ Misses 6391 6379 -12
|
|
LGTM, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo/incorrect method call in
flux wreck purgeas noticed by @trws in #1356.Also added a quick sanity of check of
flux wreck purgein tests (don't know why this was never done!), and a few other runtime fixes I stumbled across during testing.