Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-wreck cancel should send jobid as JSON number #1367

Merged
merged 2 commits into from
Mar 17, 2018

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Mar 17, 2018

Fix for encoding of jobid argument in sched.cancel command sent by flux wreck cancel as noted by @dongahn.

Also included is some removal of duplicated code in flux wreckrun

grondo added 2 commits March 17, 2018 04:19
Remove call to wreck:jobreq() in wreckrun, which is unnecssary
and duplicated in the createjob method.
Ensure the jobid in flux-wreck cancel request is encoded as
a json number, not a string.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 78.796% when pulling 574a5d4 on grondo:wreck-cancel-fixup into 0448c22 on flux-framework:master.

@codecov-io
Copy link

Codecov Report

Merging #1367 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   78.54%   78.48%   -0.07%     
==========================================
  Files         162      162              
  Lines       29741    29741              
==========================================
- Hits        23361    23342      -19     
- Misses       6380     6399      +19
Impacted Files Coverage Δ
src/modules/connector-local/local.c 72.95% <0%> (-1.44%) ⬇️
src/broker/module.c 83.79% <0%> (-1.4%) ⬇️
src/broker/content-cache.c 73.43% <0%> (-1.3%) ⬇️
src/common/libflux/rpc.c 93.38% <0%> (-0.83%) ⬇️
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/common/libflux/message.c 81.01% <0%> (-0.36%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/common/libflux/future.c 88.31% <0%> (ø) ⬆️
src/modules/kvs/kvs.c 65.21% <0%> (+0.16%) ⬆️
src/broker/overlay.c 74.45% <0%> (+0.31%) ⬆️
... and 2 more

@garlick garlick merged commit a31d49c into flux-framework:master Mar 17, 2018
@grondo grondo deleted the wreck-cancel-fixup branch March 17, 2018 15:40
@grondo grondo mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants