Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: add release notes for 0.48.0 release #4980

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

garlick
Copy link
Member

@garlick garlick commented Mar 6, 2023

Some proposed release notes for 0.48.0.

Assumes "shell: fix memory leak in doom plugin (#4979)" is merged.
Edit: oops, and also "flux-run: allow stdin to be directed to a subset of tasks (#4977)"

@garlick garlick force-pushed the relnotes_v48 branch 3 times, most recently from 58ac4d9 to f232943 Compare March 6, 2023 22:17
@garlick
Copy link
Member Author

garlick commented Mar 6, 2023

Force pushed an update to add #4892 (flux-top fix) and #4981 (SIGSTOP fix)

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Just saw one tiny grammar nit, but it's ultimately up to you, I'm pretty indifferent either way. :)

NEWS.md Outdated

This release adds submission directives ("see flux help batch") and
shortens the the job submission commands to "flux batch", "flux run",
etc.. The flux-mini(1) command is deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nit: I think when "etc." is the last word in a sentence, you do not need a second period, the period at the end of "etc" is sufficient. 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! Great catch!

https://english.stackexchange.com/questions/8382/when-etc-is-at-the-end-of-a-phrase-do-you-place-a-period-after-it

I believe I am a repeat offender:

$ cd doc
$ git grep 'etc\.\.'
man3/flux_event_decode.rst:   missing topic string, etc..
man3/flux_request_decode.rst:   missing topic string, etc..
man3/flux_response_decode.rst:   missing topic string, etc..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed fix. I'll take care of those others in #4934

@garlick garlick force-pushed the relnotes_v48 branch 2 times, most recently from 6210e71 to 8344f9b Compare March 8, 2023 00:24
@grondo
Copy link
Contributor

grondo commented Mar 8, 2023

Setting MWP. Thanks @garlick and @cmoussa1!

Problem: v0.48.0 requires release notes.

Add them.
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #4980 (8344f9b) into master (d7d6f8b) will increase coverage by 28.52%.
The diff coverage is n/a.

❗ Current head 8344f9b differs from pull request most recent head d8d4327. Consider uploading reports for the commit d8d4327 to get more accurate results

@@             Coverage Diff             @@
##           master    #4980       +/-   ##
===========================================
+ Coverage   54.57%   83.10%   +28.52%     
===========================================
  Files         409      442       +33     
  Lines       70431    76085     +5654     
===========================================
+ Hits        38439    63227    +24788     
+ Misses      31992    12858    -19134     
Impacted Files Coverage Δ
src/common/libpmi/simple_client.c 71.53% <0.00%> (-11.42%) ⬇️
src/common/libflux/response.c 79.56% <0.00%> (-10.34%) ⬇️
src/common/libflux/control.c 68.75% <0.00%> (-9.83%) ⬇️
src/common/libflux/request.c 84.76% <0.00%> (-8.65%) ⬇️
src/modules/kvs/kvs_wait_version.c 89.85% <0.00%> (-6.92%) ⬇️
src/common/libioencode/ioencode.c 89.61% <0.00%> (-6.23%) ⬇️
src/common/libsubprocess/command.c 69.81% <0.00%> (-5.64%) ⬇️
src/common/libsubprocess/util.c 94.64% <0.00%> (-5.36%) ⬇️
src/common/libsubprocess/posix_spawn.c 88.40% <0.00%> (-5.25%) ⬇️
src/common/libutil/slice.c 95.40% <0.00%> (-4.60%) ⬇️
... and 367 more

@mergify mergify bot merged commit 3400234 into flux-framework:master Mar 8, 2023
@garlick garlick deleted the relnotes_v48 branch March 15, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants