-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEWS: add release notes for 0.48.0 release #4980
Conversation
58ac4d9
to
f232943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Just saw one tiny grammar nit, but it's ultimately up to you, I'm pretty indifferent either way. :)
NEWS.md
Outdated
|
||
This release adds submission directives ("see flux help batch") and | ||
shortens the the job submission commands to "flux batch", "flux run", | ||
etc.. The flux-mini(1) command is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nit: I think when "etc." is the last word in a sentence, you do not need a second period, the period at the end of "etc" is sufficient. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! Great catch!
I believe I am a repeat offender:
$ cd doc
$ git grep 'etc\.\.'
man3/flux_event_decode.rst: missing topic string, etc..
man3/flux_request_decode.rst: missing topic string, etc..
man3/flux_response_decode.rst: missing topic string, etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed fix. I'll take care of those others in #4934
6210e71
to
8344f9b
Compare
Problem: v0.48.0 requires release notes. Add them.
Codecov Report
@@ Coverage Diff @@
## master #4980 +/- ##
===========================================
+ Coverage 54.57% 83.10% +28.52%
===========================================
Files 409 442 +33
Lines 70431 76085 +5654
===========================================
+ Hits 38439 63227 +24788
+ Misses 31992 12858 -19134
|
Some proposed release notes for 0.48.0.
Assumes "shell: fix memory leak in doom plugin (#4979)" is merged.
Edit: oops, and also "flux-run: allow stdin to be directed to a subset of tasks (#4977)"