shell: add shell.post-init plugin calllback topic between shell.init and first task.init
#5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5719 +/- ##
==========================================
- Coverage 83.46% 83.45% -0.01%
==========================================
Files 486 486
Lines 82933 82937 +4
==========================================
- Hits 69221 69218 -3
- Misses 13712 13719 +7
|
grondo
force-pushed
the
shell.post-init
branch
from
d94d01b
to
feee780
Compare
|
Thanks! I set MWP. |
Problem: The job shell does not issue any plugin callbacks between shell.init and task.init for the first task, but this may be useful if a plugin wants to take an action after all shell.init callbacks have been run, but before the first task.init callback. Add a shell.post-init callback. This runs after the shell barrier is complete but before the shell begins launching tasks.
Problem: The new shell.post-init shell plugin callback topic is not documented. Add it to flux-shell(1).
grondo
force-pushed
the
shell.post-init
branch
from
feee780
to
73b47bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR just adds a new shell plugin callback topic:
shell.post-init. This will be convenient for plugins that want to run after all other pluginshell.initcallbacks have run, but before the firsttask.initcallback (which is supposed to be task-specific).It will be used in the solution for #5718.