build: use -Wl,--gc-sections when appropriate #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: libflux-optparse.so has unresolved jansson symbols on focal. A recent macos portability change dropped the linker option to garbage collect unused sections, resulting in unresolved json_* symbols in libflux-optparse.so from libmissing.la on focal. The change, introduced in flux-framework#6476, was supposed to set a make variable $ld_gc_sections when that option is available, but the change was incomplete and the variable was never set. Add the missing configure logic. Confirmed: - json_ symbols are no longer unresolved in libflux-optparse.so on focal - macos still builds, and json_ symbols do not appear there Fixes flux-framework#6496
|
Thanks! Sorry for the sloppiness and thanks for requesting follow-up in the pmix issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6497 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 524 524
Lines 87623 87623
=======================================
+ Hits 73268 73270 +2
+ Misses 14355 14353 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: libflux-optparse.so has unresolved jansson symbols on focal.
A recent macos portability change dropped the linker option to garbage collect unused sections, resulting in unresolved json_* symbols in libflux-optparse.so from libmissing.la on focal.
The change, introduced in #6476, was supposed to set a make variable $ld_gc_sections when that option is available, but the change was incomplete and the variable was never set.
Add the missing configure logic.
Confirmed:
Fixes #6496