Add cppcheck run to travis build matrix #701
Conversation
Fix leaks in zmsg-test lua unit test to quiet cppcheck warnings.
Fix FILE handle leaks in kap detected by cppcheck.
|
Looks like there is an error that cppcheck picked up, but the test (according to Travis) still passed. |
|
Thanks I'll figure out if cppcheck isn't returning nonzero or if the wrapper script or something else is suppressing the error |
|
Ok, I guess |
|
msglist.c error seems to be a false positive to me. In any event, cppcheck error now does cause failure of the travis build (thanks @SteVwonder!), and now we'll check that a clean build passes. |
Suppress false positive doubleFree detected by cppcheck for src/common/libutil/test/msglist.c
For git checkouts specifically, include any sha1, configure options, and make options in the cache name so that package is rebuild if any one of these items change.
Add the upstream cppcheck pkg to the list of packages built for travis with travis-dep-builder.
Add a simple script to drive cppcheck in a standard way from top level flux-core srcdir.
|
This is great! Ready to merge? |
|
Yeah, this simple PR's ready |
This PR adds a new
cppcheckbuild to the Travis CI build matrix for flux-core.For the cppcheck build, a trivial script in
src/test/cppcheck.shis run instead of the normal build. In my short amount of testing this seemed to find some obvious errors like memory leaks, etc. A couple of these (in tests only) were fixed in this branch in order to run with a "clean" cppcheck initially.There are also a list of paths that
cppcheck.shignores by default, including upstream packages like liblsd, libsophia, and liblsd, as well as the autogenerated python bindings etc. The full list can be viewed (and updated) in the simplecppcheck.shscript.