Drop sophia content store back end #727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had two back ends for the content store since its inception, but only the sqlite one ever really gets used. The sophia back end requires the sophia database which we embedded. As a back end for the content store, sophia was never really properly tuned to use memory appropriately, and due to the lack of good documentation at the time, probably doesn't handle all error situations appropriately.
Now the embedded libsophia is outdated (issue #548), and is triggering some thread sanitizer warnings (issue #722).
This PR drops libsophia, the content-sophia module, and its sharness test.