Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream changes for build and charts #81

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Aug 11, 2024

Problem: the current fluence build is broken.
Solution: the issue is two fold, and unfortunately depends on the docker version. For newer docker that requires --load, that argument would be needed in the build script, and we will need to add it (and then add the script to our assets) if a newer version is used in the CI. The other breaking change was changing the location of the kube- scheduler binary in the controller image. Both of these should now be fixed, and I will update the PR further pending results in CI.

Problem: the current fluence build is broken.
Solution: the issue is two fold, and unfortunately depends on the
docker version. For newer docker that requires --load, that argument
would be needed in the build script, and we will need to add it (and
then add the script to our assets) if a newer version is used in the
CI. The other breaking change was changing the location of the kube-
scheduler binary in the controller image. Both of these should
now be fixed, and I will update the PR further pending results
in CI.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch vsoch requested review from milroy and cmisale August 12, 2024 01:27
Copy link
Collaborator

@cmisale cmisale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsoch
Copy link
Member Author

vsoch commented Aug 13, 2024

Thank you @cmisale ! Apologies for delay - haven't really checked email most of the day.

@vsoch vsoch merged commit ad764b9 into main Aug 13, 2024
8 checks passed
@vsoch vsoch deleted the fix-upstream-changes branch August 13, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants