add pod affinity and antiffinity rules #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add soft rules for the Job so Pods prefer to be scheduled on the same zone and not to be scheduled on the same node. This will improve the performance as pods in the same node will still resources from each other, and pods in different zone will have a performance penalty since networking is most likely to be worse. Signed-off-by: Antonio Ojea <aojea@google.com>
|
/assign @vsoch @alculquicondor I didn't tested but IIUIC these features will help to improve the placement of the flux pods for maximizing performance. It requires some testing |
|
This looks OK to me but I'll want to get feedback from @alculquicondor too. I'm not sure if it will muck with testing given we don't actually have different nodes there. |
|
why just preferred? |
because this is backwards compatible, a Job that ran before we'll be able to run after this change, if we make it required it may leave some Pods unschedulable , and it seems flux operator expectation is all pods are available. |
|
lgtm |
|
This looks fantastic - thank you to you both! |
vsoch
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add soft rules for the Job so Pods prefer to be scheduled on the same zone and not to be scheduled on the same node.
This will improve the performance as pods in the same node will still resources from each other, and pods in different zone will have a performance penalty since networking is most likely to be worse.