refactor: flux provisioned from init container #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
changed the title
vsoch
force-pushed
the
test-refactor-modular
branch
from
ebaa5bd
to
27b1bcf
Compare
Problem: we require flux to be packaged alongside the application logic. Solution: provide via a sidecar container with an isolated spack build.' Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
27b1bcf
to
27799d1
Compare
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
also the curve certificate needs to come from a config map so it is definitely only generated once. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
5e6617a
to
2b05c5a
Compare
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
changed the title
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
f4541cc
to
99e3fee
Compare
Need to debug pip dependencies separately Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
99e3fee
to
84d3abc
Compare
The flux restful api dependencies move too quickly for it to be a reliable production service, and further, I do not think it should be hard coded into the operator. It needs to be totally refactored and then re-added as an example application Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
2 times, most recently
from
1c01f9d
to
0a119ba
Compare
we can allow the cluster to downsize if the follower broker exits cleanly with 0, without need for the broker index max completions attribute that is enabled with a feature gate and requires k8s 1.28. This change also adds support for a minSize cluster, which will work to start the quorum when fewer than the size workers are available. note that this does not adjust tasks given to a job, so might be assigning too many tasks to too few workers. This also adds in the previous downsize workers example, except instead of using pkill for rockylinux we fall back to flux overlay disconnect, as pkill is not available by default. It is up to the user to ensure that the follower broker can be disconnected (and is not running anything). Finally, we add support for a flux->arch tag, specifically for an arm binary to be downloaded and used for the go-wait-fs command. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
e54e8b6
to
289128a
Compare
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-refactor-modular
branch
from
a733e7c
to
438bf37
Compare
This is tested and working on Google Cloud, and we also will want to test Aws Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Problem: the Commands.Init was added to replace Commands.Pre, and Commands.Pre was moved lower. But the original one was not. This means that if the user defines commands in Commands.Pre, they are run twice. Solution: remove the top one, as I think I originally intended to do Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
update controller gen
Problem: the disable view currently is adding the view bin to the path, and controller-gen had a release (today, 2/26/2024) where the go.mod is invalid for go 1.20 (minor version string not supported) and the input -i is removed. To fix this, we pin the commit from 2 days ago, and for the view, we ensure we do not change the path if it is being disabled Signed-off-by: vsoch <vsoch@users.noreply.github.com>
…roller-gen bug: openapi-gen and view PATH
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
fix: testing tim updates for generation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
changed the title
|
I am supremely tired of having this in this state, and for a review that might be superficial anyway. I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we require flux to be packaged alongside the application logic.
Solution: provide via an init container with an isolated spack build.